Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-capi-all command to Makefile for all compilers #2063

Closed
wants to merge 1 commit into from

Conversation

MarkMcCaskey
Copy link
Contributor

This is a useful command to have, maybe it should be the default?

There are still some issues with LLVM here (need to link zlib and curses) when linking against libwasmer.

Also LLVM is not detected on my computer by the Makefile even though it builds fine

Review

  • Add a short description of the the change to the CHANGELOG.md file

@syrusakbary
Copy link
Member

Yeah, it might be a good idea to make it the default!

@MarkMcCaskey
Copy link
Contributor Author

Yeah, it might be a good idea to make it the default!

I agree! but I think we need to fix the zlib and curses dependency issue before we can ship it to users. Otherwise, we'd be making it harder than it needs to be to build against wasmer

@Hywan
Copy link
Contributor

Hywan commented Jan 28, 2021

It doesn't build all the compilers, but the available compilers, is that right? We should add a line of documentation to specify that. Just a recommendation, nothing blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 bot Bip bip 🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants