-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --invoke option for emscripten files without _start function #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschutt
force-pushed
the
emscripten-nomain
branch
from
July 1, 2022 13:38
d6ce0b4
to
fe97cba
Compare
1 task
epilys
suggested changes
Jul 1, 2022
@fschutt btw can you share the emscripten files you used for testing? |
@epilys I tested it with the
I tested manually that it works (after all, it's just a single variable difference to the |
fschutt
force-pushed
the
emscripten-nomain
branch
2 times, most recently
from
July 4, 2022 12:39
66a43f8
to
8c3c7ec
Compare
epilys
approved these changes
Jul 12, 2022
epilys
force-pushed
the
emscripten-nomain
branch
from
July 12, 2022 08:41
d745baf
to
2d4edee
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running emscripten files, the CLI now supports the
--invoke
option to invoke a function by name.Review