Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new instance cache: CachedInstance #1076

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

Robbepop
Copy link
Member

This new instance cache works very different from the old one and is supposedly way more efficient.
It relies on the executor updating it whenever the currently used Instance has been changed. While the executor is in control over that the CachedInstance provides an efficient way to access Instance related data.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 93.20388% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (82d96f3) to head (69c0f01).
Report is 1 commits behind head on master.

Files Patch % Lines
crates/wasmi/src/engine/executor/cache.rs 94.54% 3 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 72.72% 3 Missing ⚠️
crates/wasmi/src/engine/executor/stack/calls.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   80.47%   80.50%   +0.03%     
==========================================
  Files         269      269              
  Lines       24974    24992      +18     
==========================================
+ Hits        20097    20120      +23     
+ Misses       4877     4872       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 6820fcc into master Jun 18, 2024
18 checks passed
@Robbepop Robbepop deleted the rf-reintroduce-instance-cache branch June 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant