Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref.is_null translation constant propagation #1189

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Robbepop
Copy link
Member

No description provided.

@Robbepop Robbepop marked this pull request as ready for review September 20, 2024 18:42
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (b48685f) to head (e3192da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/visit.rs 75.00% 3 Missing ⚠️
crates/wasmi/src/engine/translator/stack/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   80.64%   80.64%   -0.01%     
==========================================
  Files         299      300       +1     
  Lines       24511    24528      +17     
==========================================
+ Hits        19768    19781      +13     
- Misses       4743     4747       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 78788f9 into main Sep 20, 2024
15 of 18 checks passed
@Robbepop Robbepop deleted the rf-fix-ref-is-null-translation branch September 20, 2024 19:12
Robbepop added a commit that referenced this pull request Sep 20, 2024
* fix ref.is_null translation const prop

* add ValueStack::drop method

* apply rustfmt

* use ValueStack::drop where needed (fixes clippy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant