Rename instructions with immediate values + add ShiftAmount
#1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks bigs and scary but it does not introduce new instructions or change their encoding or semantics.
The new
ShiftAmount
abstractions improves type safety ofInstruction
.rhs
orlhs
is an immediate value.x_by
, e.g.shl_by
._lhs
affix from shift and rotate instructions that have an immediatevalue
.wasmi_ir::ShiftAmount
abstraction.