Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the read implementation on no-std #407

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

AldaronLau
Copy link
Contributor

Currently behavior is panicking.

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the bug fix!
How did you encounter this bug?

@AldaronLau
Copy link
Contributor Author

@Robbepop I found the bug by trying to convert the example in lib.rs to work on no-std, as I was upgrading one of my projects from an older version of wasmi. First, I had to get rid of the &mut from the call to Module::new() - then it compiled. After that, I tried loading my WASM file, and I got an unexpected panic.

@Robbepop
Copy link
Member

Robbepop commented Aug 14, 2022

@AldaronLau btw the new wasmi engine is still pretty new and therefore not yet battle hardened. We are currently in the process to change that. As of right now I would not recommend using the newest wasmi in production. We are thankful for using wasmi in non-production use cases to battle harden it thought. :)

@Robbepop Robbepop merged commit baab359 into wasmi-labs:master Aug 14, 2022
@AldaronLau
Copy link
Contributor Author

@Robbepop thanks for the warning. I don't think my project counts a "production" (it's very experimental), so I'll keep testing it.

@AldaronLau AldaronLau deleted the fix-read-impl-no-std branch August 14, 2022 05:25
@Robbepop
Copy link
Member

@AldaronLau Do you have a link to the experimental project for me?

@AldaronLau
Copy link
Contributor Author

The project is https://github.com/ardaku/quantii, which pulls in https://github.com/ardaku/ardaku, which I was updating to the new version of wasmi.

Robbepop pushed a commit that referenced this pull request Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants