-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make branch instructions offset program counter by delta (PR) #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have not yet introduced an actual difference between them in this commit.
Also rename - BranchParams::destination_pc -> target - BranchParams::update_destination_pc -> update_target
This makes Instruction again a non-generic type. Label users are now stored again but in a single Vec to allow for proper heap memory reuse. Branch targets are now branch offsets since that is going to support a single instruction pointer design in the future.
Robbepop
changed the title
Rf branch by delta
Make branch instructions offset program counter by delta (PR)
Sep 27, 2022
CRITERION BENCHMARKS
|
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 79.15% 79.24% +0.08%
==========================================
Files 73 74 +1
Lines 6255 6296 +41
==========================================
+ Hits 4951 4989 +38
- Misses 1304 1307 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #473.
This PR also introduces the
LabelRegistry
abstraction that helps build upBranchParams
during compilation of a Wasm program lazily. The newLabelRegistry
makes it possible to reuse more heap allocated memory than was possible before for some significant speedups in the range of 5-6%.Merging this PR will allow us to improve and optimize the
wasmi
bytecode executor instruction pointer.