Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize bare call overhead #522

Merged
merged 9 commits into from
Oct 18, 2022
Merged

Optimize bare call overhead #522

merged 9 commits into from
Oct 18, 2022

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Oct 18, 2022

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.30ms 1.27ms 🟢 -1.69% 1.08ms 1.10ms 🔴 1.39% 🟢 -13%
execute/
bare_call_0/typed
734.41µs 698.85µs 🟢 -4.81% 592.96µs 550.69µs 🟢 -7.08% 🟢 -21%
execute/
bare_call_1
1.37ms 1.39ms 🔴 1.78% 1.33ms 1.35ms 🔴 1.68% 🟢 -3%
execute/
bare_call_16
2.71ms 2.93ms 🔴 8.42% 4.46ms 5.02ms 🔴 12.44% 🟡 71%
execute/
bare_call_16/typed
1.73ms 1.34ms 🟢 -22.69% 2.99ms 2.38ms 🟢 -20.47% 🟡 77%
execute/
bare_call_1/typed
757.39µs 781.96µs 🔴 3.00% 727.38µs 680.35µs 🟢 -6.47% 🟢 -13%
execute/
bare_call_4
1.73ms 1.76ms 🟢 2.45% 1.99ms 2.10ms 🔴 5.33% 🟢 19%
execute/
bare_call_4/typed
941.18µs 888.92µs 🟢 -5.57% 1.08ms 985.90µs 🟢 -8.24% 🟢 11%
execute/
count_until
931.70µs 1.27ms 🔴 31.77% 2.54ms 2.38ms 🟢 -6.33% 🟡 87%
execute/
factorial_iterative
396.82ns 396.31ns ⚪ -0.18% 990.44ns 991.50ns ⚪ 0.14% 🔴 150%
execute/
factorial_recursive
749.61ns 780.25ns 🔴 3.98% 1.57µs 1.60µs 🔴 2.47% 🔴 106%
execute/
fib_iterative
1.79ms 1.87ms 🔴 4.09% 5.20ms 5.11ms 🟢 -1.68% 🔴 174%
execute/
fib_recursive
7.18ms 7.26ms 🔴 1.31% 14.70ms 14.20ms 🟢 -3.25% 🟡 96%
execute/
global_bump
1.44ms 1.33ms 🟢 -7.32% 3.63ms 3.65ms ⚪ 0.65% 🔴 174%
execute/
host_calls
32.12µs 32.31µs ⚪ 0.78% 46.46µs 44.72µs 🟢 -3.69% 🟢 38%
execute/
memory_fill
1.53ms 1.70ms 🔴 10.57% 4.38ms 4.33ms ⚪ -1.03% 🔴 155%
execute/
memory_sum
1.52ms 1.59ms 🔴 4.76% 4.36ms 4.36ms ⚪ 0.03% 🔴 175%
execute/
memory_vec_add
3.02ms 3.22ms 🔴 6.48% 8.97ms 8.96ms ⚪ -0.05% 🔴 178%
execute/
recursive_is_even
1.31ms 1.35ms 🔴 2.75% 2.55ms 2.57ms ⚪ 0.93% 🟡 91%
execute/
recursive_ok
183.33µs 184.00µs ⚪ 2.46% 367.88µs 358.54µs 🟢 -2.47% 🟡 95%
execute/
recursive_scan
221.22µs 218.42µs 🟢 -1.33% 459.82µs 460.65µs ⚪ 0.27% 🔴 111%
execute/
recursive_trap
17.36µs 17.25µs ⚪ -0.63% 35.43µs 35.53µs ⚪ 0.35% 🔴 106%
execute/
regex_redux
675.07µs 700.94µs 🔴 3.88% 1.59ms 1.61ms ⚪ 0.74% 🔴 129%
execute/
rev_complement
586.57µs 623.74µs 🔴 6.20% 1.56ms 1.55ms ⚪ -0.78% 🔴 148%
execute/
tiny_keccak
454.79µs 495.74µs 🔴 8.87% 1.42ms 1.42ms ⚪ -0.53% 🔴 186%
execute/
trunc_f2i
1.07ms 1.02ms 🟢 -4.34% 2.73ms 2.72ms ⚪ -0.24% 🔴 166%
instantiate/
wasm_kernel
66.78µs 70.92µs 🔴 6.60% 93.69µs 94.17µs ⚪ 0.60% 🟢 33%
translate/
wasm_kernel
4.82ms 4.91ms ⚪ 1.43% 9.58ms 10.17ms 🔴 6.16% 🔴 107%

Link to pipeline

@Robbepop Robbepop merged commit 00bbcd0 into master Oct 18, 2022
@Robbepop Robbepop deleted the rf-opt-call-overhead branch October 18, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants