Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve CLI parsing #596

Merged
merged 2 commits into from
Dec 28, 2022
Merged

CLI: Improve CLI parsing #596

merged 2 commits into from
Dec 28, 2022

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.58ms 1.60ms 🔴 2.11% 1.34ms 1.27ms 🟢 -4.83% 🟢 -21%
execute/
bare_call_0/typed
961.89µs 962.78µs ⚪ 0.12% 692.86µs 693.35µs ⚪ -0.19% 🟢 -28%
execute/
bare_call_1
1.63ms 1.65ms 🔴 1.51% 1.63ms 1.58ms 🟢 -2.85% 🟢 -4%
execute/
bare_call_16
2.64ms 2.66ms 🔴 0.56% 4.81ms 4.80ms ⚪ -0.11% 🟡 80%
execute/
bare_call_16/typed
1.72ms 1.83ms 🔴 6.39% 2.37ms 2.37ms ⚪ 0.05% 🟢 30%
execute/
bare_call_1/typed
1.07ms 1.06ms ⚪ -1.06% 1.14ms 1.07ms 🟢 -5.58% 🟢 1%
execute/
bare_call_4
1.80ms 1.79ms ⚪ -0.67% 2.31ms 2.27ms 🔴 -1.96% 🟢 27%
execute/
bare_call_4/typed
1.09ms 1.10ms ⚪ 0.66% 1.17ms 1.19ms 🔴 1.40% 🟢 8%
execute/
br_table
1.08ms 1.11ms ⚪ 1.38% 1.35ms 1.31ms 🟢 -3.63% 🟢 18%
execute/
count_until
710.96µs 650.82µs ⚪ -4.05% 2.14ms 2.15ms ⚪ 0.00% 🔴 230%
execute/
factorial_iterative
320.69µs 319.86µs ⚪ 0.08% 927.68µs 910.30µs 🟢 -1.77% 🔴 185%
execute/
factorial_recursive
628.98µs 632.71µs ⚪ 0.57% 1.37ms 1.36ms ⚪ -0.48% 🔴 115%
execute/
fib_iterative
1.51ms 1.51ms ⚪ -0.08% 4.98ms 4.96ms ⚪ -0.42% 🔴 228%
execute/
fib_recursive
5.70ms 6.32ms 🔴 10.31% 12.19ms 12.04ms 🟢 -1.42% 🟡 90%
execute/
global_bump
920.24µs 921.59µs ⚪ 0.15% 3.15ms 3.17ms ⚪ 0.56% 🔴 244%
execute/
global_const
741.64µs 741.77µs ⚪ -0.02% 2.47ms 2.47ms ⚪ 0.09% 🔴 233%
execute/
host_calls
29.56µs 30.05µs ⚪ 0.51% 42.08µs 42.23µs ⚪ 0.58% 🟢 41%
execute/
memory_fill
1.33ms 1.33ms ⚪ -0.04% 4.25ms 4.25ms ⚪ 0.20% 🔴 219%
execute/
memory_sum
1.30ms 1.30ms ⚪ -0.22% 4.19ms 4.23ms ⚪ 1.08% 🔴 225%
execute/
memory_vec_add
2.64ms 2.67ms 🔴 1.36% 8.73ms 8.73ms ⚪ -0.25% 🔴 226%
execute/
recursive_is_even
1.12ms 1.12ms ⚪ -0.26% 2.23ms 2.20ms ⚪ -3.64% 🟡 97%
execute/
recursive_ok
142.37µs 142.10µs ⚪ -0.26% 307.66µs 306.40µs ⚪ -0.39% 🔴 116%
execute/
recursive_scan
181.44µs 179.93µs ⚪ -0.96% 397.40µs 394.22µs ⚪ -0.70% 🔴 119%
execute/
recursive_trap
13.81µs 13.81µs ⚪ 0.00% 30.84µs 30.60µs ⚪ -0.69% 🔴 122%
execute/
regex_redux
545.86µs 546.83µs ⚪ 0.42% 1.55ms 1.57ms ⚪ 1.12% 🔴 187%
execute/
rev_complement
504.08µs 503.29µs ⚪ -0.22% 1.58ms 1.58ms ⚪ 0.17% 🔴 214%
execute/
tiny_keccak
355.34µs 361.75µs 🔴 1.86% 1.27ms 1.27ms ⚪ 0.72% 🔴 252%
execute/
trunc_f2i
906.78µs 907.40µs ⚪ 0.03% 2.62ms 2.63ms ⚪ 0.39% 🔴 190%
instantiate/
wasm_kernel
61.58µs 58.31µs 🟢 -5.52% 72.12µs 71.53µs ⚪ 0.73% 🟢 23%
translate/
erc1155
210.24µs 206.70µs 🟢 -1.48% 409.09µs 403.61µs 🟢 -1.35% 🟡 95%
translate/
erc20
102.24µs 101.44µs ⚪ -0.73% 199.55µs 199.40µs ⚪ -0.17% 🟡 97%
translate/
erc721
147.91µs 145.64µs 🟢 -1.54% 291.69µs 287.06µs 🟢 -1.90% 🟡 97%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.33% 0.00ns 0.00ns 🟢 -2.04% 🟢 0%
translate/
wasm_kernel
3.89ms 3.89ms ⚪ 0.31% 7.68ms 7.56ms 🟢 -1.62% 🟡 94%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #596 (47e45fd) into master (da8e4a6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files          80       80           
  Lines        6416     6416           
=======================================
  Hits         5182     5182           
  Misses       1234     1234           
Impacted Files Coverage Δ
crates/cli/src/main.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 2b5a486 into master Dec 28, 2022
@Robbepop Robbepop deleted the rf-improve-cli branch December 28, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants