Update to Rust 1.77 #961
Merged
Update to Rust 1.77 #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we are going to use the new slice::chunk_by API in Wasmi.
This allows us to drop the slice-group-by dependency entirely.
- Now supports native {f32,f64}::round_ties_even
- Uses traits instead of modules for adapter definitions
- Pushed tests to bottom of the file and into their own test module
- Improved macro hygiene (wasn't a problem before)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 81.74% 81.89% +0.15%
==========================================
Files 259 259
Lines 23954 23886 -68
==========================================
- Hits 19580 19562 -18
+ Misses 4374 4324 -50 ☔ View full report in Codecov by Sentry. |
These were used for a single internal implementation and thus could easily be substituted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to
{f32,f64}::round_ties_eveninwasmi_coreslice::chunk_bywhich allows us to drop an entire crates.io dependencyThis PR also includes some refactoring of how
libmis used inwasmi_core.