-
Notifications
You must be signed in to change notification settings - Fork 81
Automatically find workspaces of all local dependencies and watch them. #216
Conversation
Closed/reopened to trigger the builds after I changed the base branch. |
Okay, that's looking good, even if it's somewhat different from #117 (but probably covers the original usecase). If you could add this behaviour to the readme/usage/manpage as needed, I'll merge and release this asap! |
I've pushed a new version of my change. Changes since last time:
You mention this change is not what was discussed in the feature request. What do you think is different? I'm happy to change the PR into a form you think is useful. |
Yeah, actually, upon further reflection, this PR changes the current behaviour quite a bit. Say we have the following structure:
Now consider this other structure:
|
I see. I thought I'd simplify the logic a bit because watching only the workspace root is probably fine :) I'll write up a new version which is more precise in what it tracks. |
I think the latest version should fit what you describe. |
This watches the package directories of all dependencies which are local, plus the package directory of the current project. This has no effect if --watch/-w is manually specified. Add --skip-local-deps which disables this new behaviour. Fixes #117.
Fixed the compile error. |
Sorry for the delay! The code looks good, I just want to check a few more things and I haven't gotten to it yet. |
This watches the workspace roots of all dependencies which are local, plus the workspace root of the current project. This has no effect if --watch/-w is manually specified.
Fixes #117.
It's very possible I'm missing some nuances though! Maybe this breaks in certain constellations of where cargo is invoked? Please let me know if I'm missing something.