Support a dedicated ignore file #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref. watchexec/cargo-watch#127 This adds support for a dedicated ignore file by the name of `.ignore` a la `fd`, `ripgrep`, et. al. This purely just mimics what `Gitignore` is doing except it doesn't ignore `.git` directories. There might be more I need to tweak and the interface might be too obtuse, but this is a first pass. I've also added a `--no-ignore` flag which ignores both `.gitignore` and the dedicated `.ignore`. It might make sense to add a specific flag that ignores `.ignore` but respects `.gitignore` to support the old behaviour, but I wasn't sure what to name it.
|
This all looks great! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. watchexec/cargo-watch#127
This adds support for a dedicated ignore file by the name of
.ignoreala
fd,ripgrep, et. al.This purely just mimics what
Gitignoreis doing except it doesn'tignore
.gitdirectories. There might be more I need to tweak and theinterface might be too obtuse, but this is a first pass.
I've also added a
--no-ignoreflag which ignores both.gitignoreandthe dedicated
.ignore. It might make sense to add a specific flag thatignores
.ignorebut respects.gitignoreto support the oldbehaviour, but I wasn't sure what to name it.