PIC18 PWM Driver #21
Merged
PIC18 PWM Driver #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonBrave
requested changes
Oct 2, 2024
JasonBrave
requested changes
Oct 13, 2024
taisirhassan
force-pushed
the
port-pwm-driver-pic18f26k83
branch
from
8a63c36 to
eecee6e
Compare
JasonBrave
requested changes
Oct 13, 2024
taisirhassan
force-pushed
the
port-pwm-driver-pic18f26k83
branch
from
cfc6e61 to
a64028d
Compare
JasonBrave
requested changes
Oct 29, 2024
taisirhassan
force-pushed
the
port-pwm-driver-pic18f26k83
branch
from
7d2da67 to
ca1127b
Compare
… switch cases for certain CCP modules using PPS. We should change this to either a macro function or a helper function to simplify it.
- Updated `updatePulseWidth()` to compute and set the duty cycle value for any CCP module (CCP1-CCP4). - Removed module-specific constants, using dynamic calculations to determine the 10-bit duty cycle. - Added range checking to ensure duty cycle values remain within 0-1023.
- Added macros in `pwm.h` to replace repetitive switch-case logic, simplifying PWM initialization and duty cycle configuration. - Updated `pwm.c` to use the new macros for configuring CCP pin mappings, CCP mode, output pins, and duty cycle values.
…eturn type to status_t
Co-authored-by: Jason Xu <[email protected]>
…pdatepulsewidth function
…e a Struct to allow dynamic pin mapping instead of a macro which was rigid; add PPS configuration support and update documentation
taisirhassan
force-pushed
the
port-pwm-driver-pic18f26k83
branch
from
4beb480 to
6897a2d
Compare
JasonBrave
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.