add VMD, PGMD/CGMD #1466
add VMD, PGMD/CGMD #1466
Conversation
This reverts commit 42005cf.
|
@ElmiraShamlou, any update on this? |
I'll be pushing one more commit, and then it will be ready for review. |
What's the news here? |
…rking as expected
Co-authored-by: Adam Atia <[email protected]>
There was a problem hiding this comment.
You've done a lot of great work. It is clear that a significant amount of effort went into this PR. I think we are close, but I do have one particularly painful ask--can you update the documentation on MD to cover the configuration types and 1D config? Perhaps you could point to 0d doc in the 1d doc for the equations and variables, but more importantly, I think that we should be describing DCMD, VMD, PGMD and CGMD for users so that these models can be more accessible and comprehensible.
@adam-a-a Thank you for the comment and feedback. The documentation has been updated to cover the new configuration types (DCMD, VMD, PGMD, and CGMD), and a separate file has been added for the 1D model. |
docs/technical_reference/unit_models/membrane_distillation_0D.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/unit_models/membrane_distillation_0D.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/unit_models/membrane_distillation_0D.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/unit_models/membrane_distillation_1D.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/unit_models/membrane_distillation_0D.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/unit_models/membrane_distillation_1D.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
Co-authored-by: MarcusHolly <[email protected]>
* add VMD, PGMD/CGMD * modifies gap heat conduction * black * modifies scaling factor calculations * VMD modifications * modifications for PGMD * black * modifies VMD * modifies PGMD * Revert "updates" This reverts commit 3792195, reversing changes made to 8070194. * Reapply "updates" This reverts commit 42005cf. * 1D VMD and PGMD * resolve PGMD heat balance issue at inlet for 0D model. PGMD 1D was working as expected * refine tests * revise tests * black * linting * resolve doc issue * resolve doc issue * refine tests * resolve doc issue * improve scaling * Update watertap/unit_models/MD/membrane_distillation_1D.py Co-authored-by: MarcusHolly <[email protected]> * Update watertap/unit_models/tests/test_membrane_distillation_0D.py Co-authored-by: Adam Atia <[email protected]> * add docs for new configs and 1D MD * resolve doc issue * doc revise * Update docs/technical_reference/unit_models/membrane_distillation_1D.rst Co-authored-by: MarcusHolly <[email protected]> * Update docs/technical_reference/unit_models/membrane_distillation_0D.rst Co-authored-by: MarcusHolly <[email protected]> * Update docs/technical_reference/unit_models/membrane_distillation_1D.rst Co-authored-by: MarcusHolly <[email protected]> * Update docs/technical_reference/unit_models/membrane_distillation_0D.rst Co-authored-by: MarcusHolly <[email protected]> * Update docs/technical_reference/unit_models/membrane_distillation_1D.rst Co-authored-by: MarcusHolly <[email protected]> * rename PGMD_CGMD to GMD * categorize equations based on MD config type --------- Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: MarcusHolly <[email protected]> Co-authored-by: Adam Atia <[email protected]> (cherry picked from commit 9eb240e)
add vmd, pgmd and cgmd for membrane distillation
Fixes/Resolves: