Automatically Double Function Keywords, Engine-Defined Default Arguments & User-Defined Default Arguments #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users should no longer need to pass in a keyword for functions like master, puppet, static etc. Default arguments (both godot-default and user-defined) should also be doubled automatically. - Inner classes need to be resupported - Weird issues with _init & dependecies
We can't auto handle default args or keywords here because it would require ridicolous parsing and I don't think inner classes are popular enough to justify that work load.
Some cases we can't do these automatically, such as inner klasses, so we should still provide the option to override. This also allows some backwords compat for time being
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well we finally goddamn well did it. This feature was a pretty massive undertaking but we got it there eventually.
There is one single caveat: We can't do this automatically with inner classes but I did leave the option to add in a keyword and return value if needed. Nothing for default arguments though. I don't think supporting that level of parsing will be necessary because as is, it seems inner classes overall aren't very popular, even if used.
But beyond that, woohoo!