-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2
core module support
#7
Comments
silverwind
added a commit
to silverwind/original-url
that referenced
this issue
Oct 6, 2020
Add support for node code http2 in compatibility mode. Differences: - req.secure is replaced by req.scheme - req.headers.host is replaced by req.headers['authority'] Fixes: watson#7
silverwind
added a commit
to silverwind/original-url
that referenced
this issue
Oct 6, 2020
Add support for node code http2 in compatibility mode. Differences: - req.secure is replaced by req.scheme - req.headers.host is replaced by req.headers['authority'] Fixes: watson#7
silverwind
added a commit
to silverwind/original-url
that referenced
this issue
Oct 6, 2020
Add support for node code http2 in compatibility mode. Differences: - req.secure is replaced by req.scheme - req.headers.host is replaced by req.headers['authority'] Fixes: watson#7
Hi, I guess here we can follow the progressive enhancement approach. So we use http2 headers when present and fallback to the current behavior for backwards compatibility and non http2 requests. |
#8 does it the other way around, it first checks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http2 has different semantics for communicating the
host
header. Inhttp
a simple request results in thesereq.headers
:while in
http2
it is:So for minimum support,
:authority
could be used instead ofhost
. It may be worth considering using:path
and:scheme
as well but I guess that info is probably just duplicate withreq.url
orreq.secure
.The text was updated successfully, but these errors were encountered: