Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS node_options variable and Kibana plugin optimization #385

Merged
merged 13 commits into from
Mar 13, 2020

Conversation

Zenidd
Copy link
Contributor

@Zenidd Zenidd commented Mar 10, 2020

Hi team,

  • This PR adds a new variable (node_options) that allows a space-separated list of command-line options to be added so they are taken into account by the Kibana launch script.

  • On the other hand, it also adds a new task for Kibana plugin optimization into the ansible-kibana set of tasks.

Greetings, JP Sáez

@Zenidd Zenidd requested review from manuasir and jm404 March 10, 2020 14:48
@Zenidd Zenidd self-assigned this Mar 10, 2020
@andymotta
Copy link

andymotta commented Mar 10, 2020

I had also enabled options for --max-old-space-size=4096 before seeing this feature branch. This is the behaviour we were seeing with out of the box defaults:

Mar 10 18:26:25 wazuh-server kibana[2609]: {"type":"log","@timestamp":"2020-03-10T18:26:25Z","tags":["info","optimize"],"pid":2609,"message":"Optimizing and caching bundles for core, graph, monitoring, space_selector, login, overwritten_session, logout, logged_out, ml, dashboardViewer, apm, maps, canvas, infra, siem, uptime, lens, wazuh, kibana, stateSessionStorageRedirect, status_page and timelion. This may take a few minutes"}
Mar 10 18:30:58 wazuh-server kibana[2609]: <--- Last few GCs --->
Mar 10 18:30:58 wazuh-server kibana[2609]: [2609:0x3b20f40]   288840 ms: Mark-sweep 1300.4 (1397.9) -> 1300.4 (1397.9) MB, 1743.9 / 0.0 ms  (average mu = 0.267, current mu = 0.000) last resort GC in old space requested
Mar 10 18:30:58 wazuh-server kibana[2609]: [2609:0x3b20f40]   290619 ms: Mark-sweep 1300.4 (1397.9) -> 1300.4 (1397.9) MB, 1779.1 / 0.0 ms  (average mu = 0.150, current mu = 0.000) last resort GC in old space requested
Mar 10 18:30:58 wazuh-server kibana[2609]: <--- JS stacktrace --->
Mar 10 18:30:58 wazuh-server kibana[2609]: ==== JS stack trace =========================================
Mar 10 18:30:58 wazuh-server kibana[2609]:     0: ExitFrame [pc: 0x3d5550e5be1d]
Mar 10 18:30:58 wazuh-server kibana[2609]: Security context: 0x0d8c7a21e6e9 <JSObject>
Mar 10 18:30:58 wazuh-server kibana[2609]:     1: add [0xd8c7a211831](this=0x1fed594415e9 <Set map = 0x3222ba4841f9>,0x2463011e4141 <JSArray[0]>)
Mar 10 18:30:58 wazuh-server kibana[2609]:     2: prepend_comments [0x1ee055e0f549] [/usr/share/kibana/node_modules/terser/dist/bundle.min.js:~1] [pc=0x3d5551ee6841](this=0x029e5678a7e9 <Object map = 0x12fd8331d321>,t=0x0419d287df99 <AST_Dot map = 0x1e39db865e61>)
Mar 10 18:30:58 wazuh-server kibana[2609]:     3: /* anonymous */(aka /* anony...
Mar 10 18:30:58 wazuh-server kibana[2609]: FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Mar 10 18:30:58 wazuh-server kibana[2609]:  1: 0x8fa090 node::Abort() [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  2: 0x8fa0dc  [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  3: 0xb0052e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  4: 0xb00764 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  5: 0xef4c72  [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  6: 0xf0448f v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  7: 0xecd4e6 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  8: 0xecdd6a v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]:  9: 0xecde10 v8::internal::Handle<v8::internal::FixedArray> v8::internal::Factory::NewFixedArrayWithMap<v8::internal::FixedArray>(v8::internal::Heap::RootListIndex, int, v8::internal::PretenureFlag) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]: 10: 0x1059df7 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::Allocate(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]: 11: 0x105d0bb v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::Rehash(v8::internal::Handle<v8::internal::OrderedHashSet>, int) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]: 12: 0x105d689 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::EnsureGrowable(v8::internal::Handle<v8::internal::OrderedHashSet>) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]: 13: 0x1141dce v8::internal::Runtime_SetGrow(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/share/kibana/bin/../node/bin/node]
Mar 10 18:30:58 wazuh-server kibana[2609]: 14: 0x3d5550e5be1d

@Zenidd Zenidd requested review from rshad and xr09 March 13, 2020 09:31
@Zenidd
Copy link
Contributor Author

Zenidd commented Mar 13, 2020

Hello @andymotta,

Several users have been reporting to us in our Slack community channel that they encountered this problem during kibana optimization.

Thank you for let us know that this is not something happening just in our lab environments. Please feel free to contribute other solutions or workarounds that worked in your environment in any other context.

Greetings,
JP Sáez

@Zenidd Zenidd requested a review from xr09 March 13, 2020 11:24
Copy link
Contributor

@xr09 xr09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jm404 jm404 added this to the Sprint-108 milestone Mar 13, 2020
@jm404 jm404 merged commit 7f1ed0a into devel Mar 13, 2020
@jm404 jm404 deleted the feature-node_options-variable branch March 13, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants