Add support to configure path.repo option in ES. Required for backups/snapshots #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm404
approved these changes
Jun 18, 2020
manuasir
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to configure option
path.repoin our elasticsearch instance to do snapshots and backups. e.g.This PR should not change the current default behaviour of the role. Using the default value
elasticsearch_path_repo: []just won't add anything to the ES configThe paths defined in
elasticsearch_path_reposhould exist and be writable by the ES daemon but the role is not taking care of creating them. Is ok like that or should I extend the PR to create the folders with the right permissions? Please let me know what you prefer.