Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kibana extra ssl option #451

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Add kibana extra ssl option #451

merged 2 commits into from
Jul 22, 2020

Conversation

xr09
Copy link
Contributor

@xr09 xr09 commented Jul 20, 2020

This is a follow up for #426

@xr09 xr09 self-assigned this Jul 20, 2020
@xr09 xr09 mentioned this pull request Jul 20, 2020
Closed
@xr09 xr09 requested review from manuasir and Zenidd July 21, 2020 11:28
Zenidd
Zenidd reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@Zenidd Zenidd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we use none as default value for elasticsearch.ssl.verificationMode ?

@xr09
Copy link
Contributor Author

xr09 commented Jul 22, 2020

The default value for this setting is "full".

Do you mean using a null value and only rendering the variable in the template if it does contain a valid value?

@xr09 xr09 requested a review from Zenidd July 22, 2020 09:09
manuasir
manuasir approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@manuasir manuasir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuasir manuasir merged commit 1b50c4c into devel Jul 22, 2020
@manuasir manuasir deleted the pr-426-kibana_extra_ssl_option branch July 22, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuasir manuasir manuasir approved these changes

@Zenidd Zenidd Awaiting requested review from Zenidd

Assignees

@xr09 xr09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xr09 @manuasir @Zenidd @pescobar