Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for opendistro role #453

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fixes for opendistro role #453

merged 2 commits into from
Jul 27, 2020

Conversation

xr09
Copy link
Contributor

@xr09 xr09 commented Jul 24, 2020 •
edited
Loading

This PR fixes a typo on opendistro role defaults and adds a check to only execute the custom user task when the variable is not null

@xr09 xr09 self-assigned this Jul 24, 2020
@xr09 xr09 force-pushed the fix-demo-custom-user branch from 0e2673b to f870da4 Compare July 27, 2020 11:27
@xr09 xr09 changed the title Check for custom_user_role Fixes for opendistro role Jul 27, 2020
@xr09 xr09 marked this pull request as ready for review July 27, 2020 11:48
@xr09 xr09 requested review from Zenidd and manuasir July 27, 2020 11:48
manuasir
manuasir approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@manuasir manuasir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuasir manuasir merged commit 8580a01 into devel Jul 27, 2020
@manuasir manuasir deleted the fix-demo-custom-user branch July 27, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zenidd Zenidd Zenidd approved these changes

@manuasir manuasir manuasir approved these changes

Assignees

@xr09 xr09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xr09 @manuasir @Zenidd