-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vulnerabilities dashboards] Add global vulnerabilities dashboards #5896
Conversation
…boards (#5947) * Add useDashboardConfiguration and unit test hook * Changed how the initial hook configuration is set
* Add search bar hooks * Rename searchbar hook * Add unit test to use search bar configuration hook * Fix some unit test titles * Remove console.log * Solve requested changes * Fix request changes and hook filename
…rch bar by default (#5970) Remove agent id filter in searchbar
* Add data grid hook * Add doc viewer component and hook * Add ui utils components * Add new vuls inventory component * Add vuls inventory in module rendering * Add full height container * Add inventory table columns * Remove columns fields filter by keyword type
…d plugins (#5966) * Add useDashboardConfiguration and unit test hook * Changed how the initial hook configuration is set * Create dashboard using embedded visualizations by value. * [Vulnerabilities dashboards] Add search bar services (#5960) * Add search bar hooks * Rename searchbar hook * Add unit test to use search bar configuration hook * Fix some unit test titles * Remove console.log * Solve requested changes * Fix request changes and hook filename * [Vulnerabilities dashboards] Fix wrong agent.id filters loaded in search bar by default (#5970) Remove agent id filter in searchbar * Recommended filters are added and communication problems between the dashboard and the searchbar are solved * Update Vulnerability detector dashboard filters visualization and VULNERABILITIES_INDEX_PATTERN_ID constant * Change KPI dashboard and fix bad request * Separates filter panels from dashboard panels * Add Accumulation of the most detected vulnerabilities visualization and change --------- Co-authored-by: Maximiliano Ibarra <[email protected]>
Fix vulnerability dashboard filters
…vuls dashboard tab
|
CR 🟢TEST 🟢
Details🟢 Check that the dashboard tab looks like the reference in the commentChrome 🟢 Light modeDark mode🟢 Check that the inventory tab looks like the reference in the commentChrome 🟢 Light modeDark mode🟢 Use search bar input to filter any word and check if the dashboard shows the corresponding resultsChrome 🟢 🟢 Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filterChrome 🟢 🟡 Add a filter through interaction with a visualization and check that the dashboard updatesChrome 🟡 When the user clicks on the 🟢 Use search bar input to filter any word and check if the table shows the corresponding resultsChrome 🟢 🟢 Use the add filters button, select any filter and check if the table shows the corresponding resultsChrome 🟢 🟡 Use the page and rows per page selector, and check if is working as expectedChrome 🟡 Pagination 🟡Error message:
Rows per page 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
TEST
Test | Result |
---|---|
Check that the dashboard tab looks like the reference in the comment (#5896 (comment)). | 🟢 |
Check that the inventory tab looks like the reference in the comment (#5896 (comment)). | 🟢 |
Use search bar input to filter any word and check if the dashboard shows the corresponding results. | 🟢 |
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter. | 🟢 |
Add a filter through interaction with a visualization and check that the dashboard updates. | 🟡 |
Add a filter on search bar and the dashboard changes according to the applied filter. | 🟢 |
Use search bar input to filter any word and check if the table shows the corresponding results. | 🟢 |
Use the input and type an incorrect word to check if the no results message is shown. | 🟢 |
Use the add filters button, select any filter and check if the table shows the corresponding results. | 🟢 |
Use the page and rows per page selector, and check if is working as expected. | 🟡 |
Use the data grid toolbar controls functionality (columns selector, density, sort fields, full screen). | 🟡 |
Use export formatted control (export table to CSV button). | 🟡 |
Use the header columns controls (column visibility, column sorting, column position). | 🟢 |
Click on the inspect document button and check the flyout functionality, the details must show the row clicked on the table. | 🟢 |
DETAILS
🟢 Check that the dashboard tab looks like the reference in the comment (https://github.com//pull/5896#issuecomment-1790919849).
🟢 Check that the inventory tab looks like the reference in the comment (https://github.com//pull/5896#issuecomment-1789606985)
🟢 Use search bar input to filter any word and check if the dashboard shows the corresponding results.
🟢 Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter.
🟢 Use the add filters button, select any filter and check if the table shows the corresponding results.
🟡 Use the page and rows per page selector, and check if is working as expected
NOTE: Bad request when from + size is not less than or equal to 10000
Related documentation: https://opensearch.org/docs/latest/im-plugin/index-settings/#dynamic-index-settings
🟡 Use the data grid toolbar controls functionality (columns selector, density, sort fields, full screen) and Use the header columns controls (column visibility, column sorting, column position).
🟢 Columns selector
🟢 Density
🟡 Sort fields
NOTE: When dragging the sort fields the background turns red but then they swap correctly
Description
This PR, adds the following features:
Closes #5763
Test
Check List
yarn test:jest