-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected and finished the debug option for the unified unattended installer #1042
Conversation
…unattended-installer.log if called from unattended
a35e181
to
fbe48ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to have multiple logger functions?
and with different logfiles?
logger() {
logger_cert() {
logger_pass() {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just a minor change. Review calls to echo, it must use logger
echo -e "Elasticsearch installation failed" |
Changed in f97aeaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0bb4f70
to
e8fd01a
Compare
e8fd01a
to
6daa42d
Compare
Signed-off-by: verdx <[email protected]>
… Dani Signed-off-by: verdx <[email protected]>
Signed-off-by: verdx <[email protected]>
Signed-off-by: verdx <[email protected]>
Description
The PR does several changes:
wazuh-cert-tool.sh
andwazuh-password-tool.sh
have separate loggers when called individually but print to the general logger when called from the main functioncommon.sh
tounattended_installer.sh
${debug}
from thecd
commands that couldn't be removedLogs example
All-in-one installation shell output:
Contents of
wazuh-unattended-installation.log
:Tests