Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kibana app] Support pluginPlatform.version property in the app manifest #1208

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 26, 2022

Related issue
None

Description

This PR adds compatibility to use the pluginPlatform.version property package.json. It keeps the compatibility with previous versions that used kibana.version.

Starting with the Kibana apps for Wazuh 4.3.0, the kibana property in the root of package.json was renamed to pluginPlatform.

Logs example

Tests

  • Build the Kibana app package:
    • using pluginPlatform.version property
    • using kibana.version property

… package.json when getting the plugin platform version

  - Keeps the retrocompatibility with previous versions using the `kibana.version` property
@Desvelao Desvelao force-pushed the fix/4.3-support-plugin-platform-property-in-package-manifest branch from 7f0bcd4 to af96126 Compare January 26, 2022 11:36
Copy link
Contributor

@DFolchA DFolchA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DFolchA DFolchA merged commit 712361c into 4.3 Jan 26, 2022
@DFolchA DFolchA deleted the fix/4.3-support-plugin-platform-property-in-package-manifest branch January 26, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants