Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sca files for MS IIS, Oracle Database 19c, MongoDB 3.6, Nginx, SQL Server and SLES #797

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Add new sca files for MS IIS, Oracle Database 19c, MongoDB 3.6, Nginx, SQL Server and SLES #797

merged 3 commits into from
Jun 14, 2021

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented Jun 10, 2021

Related issue
closes #783

Description

This PR adds the new MS IIS, Oracle Database 19c, MongoDB 3.6, Nginx, SQL Server and SLES SCA files to the SPECS

Logs example

Tests

  • Build the package in any supported platform
    • Linux
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package

@DFolchA DFolchA requested review from alberpilot and okynos June 10, 2021 14:21
@DFolchA DFolchA self-assigned this Jun 10, 2021
@DFolchA DFolchA changed the title 783 add new sca Add new sca files for MS IIS, Oracle Database 19c, MongoDB 3.6, Nginx, SQL Server and SLES Jun 10, 2021
okynos
okynos approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@okynos okynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@72nomada 72nomada merged commit b83f8e4 into master Jun 14, 2021
@72nomada 72nomada deleted the 783-add-new-sca branch June 14, 2021 11:16
@okynos okynos mentioned this pull request Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberpilot alberpilot alberpilot approved these changes

@okynos okynos okynos approved these changes

Assignees

@DFolchA DFolchA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SPECS for SCA CIS policies for MS IIS, Oracle Database 19c, MongoDB 3.6, Nginx, SQL Server and SLES
4 participants
@DFolchA @alberpilot @okynos @72nomada