Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creation of wpk for macOS and add wpk_root.pem to .pkg package #855

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Allow creation of wpk for macOS and add wpk_root.pem to .pkg package #855

merged 3 commits into from
Oct 1, 2021

Conversation

Nicogp
Copy link
Member

@Nicogp Nicogp commented Sep 7, 2021 •
edited by TomasTurina
Loading

Related issue
#823

Description

This PR adds all the necessary changes to allow creation of WPK for macOS and adds the wpk_root.pem file when creating a .pkg package.

Tests

  • Build the package in any supported platform
    • macOS
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave

@TomasTurina TomasTurina marked this pull request as ready for review September 7, 2021 19:15
@TomasTurina TomasTurina removed their request for review September 7, 2021 19:15
okynos
okynos approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@okynos okynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

DFolchA
DFolchA approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@DFolchA DFolchA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikman90 vikman90 merged commit 3bc8605 into master Oct 1, 2021
@vikman90 vikman90 deleted the 3913_macos_wpk branch October 1, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okynos okynos okynos approved these changes

@DFolchA DFolchA DFolchA approved these changes

Assignees

@Nicogp Nicogp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nicogp @okynos @DFolchA @vikman90 @TomasTurina