Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unattended script missing escape character [master] #923

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

verdx
Copy link
Contributor

@verdx verdx commented Oct 13, 2021

Related issue
#869

Description

I have added an escape character before $ in both the scripts for the opendistro and elastic unattended installs so that when the repo is created, the version of the release is shown correctly

Logs example

Tests

It has been tested in CentOS 5,6,7 and 8

@verdx verdx self-assigned this Oct 13, 2021
@verdx verdx requested review from alberpilot and DFolchA October 13, 2021 10:38
@verdx verdx changed the title Added escape characters to unattended scripts Unattended script missing escape character Oct 13, 2021
Copy link
Contributor

@DFolchA DFolchA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DFolchA DFolchA merged commit 01ff602 into master Oct 26, 2021
@DFolchA DFolchA deleted the 869-unattended-missing-escape-master branch October 26, 2021 12:15
@verdx verdx changed the title Unattended script missing escape character Unattended script missing escape character [master] Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants