-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wazuh-passwords-tool.sh so it doesn't remove the password in kibana.yml [master] #930
Conversation
@@ -275,7 +275,7 @@ changePassword() { | |||
restartService "filebeat" | |||
fi | |||
|
|||
if [ -n "${haskibana}" ]; then | |||
if [[ -n "${haskibana}" ]] && [[ -n "${kibpass}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error in the provided log related to this line, please fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the updated logs, I also had to fix a previous error that impeded kibana's password being changed. The error was the changing of kibana password was inside an if statement only entered when the wazuh password or all of them were changed. I have taken it out and created a similar if statement for when the kibana password is changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…/wazuh-packages into 920-password-kibana-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
I have changed wazuh-passwords-tool.sh so that it only changes the kibana.yml elasticsearch password if the user or one of the users changed is kibanaserver
Logs example
Tests
Checked on CentOS 7 and Ubuntu 18