Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chkconfig from RPM SPECS #977

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Remove chkconfig from RPM SPECS #977

merged 2 commits into from
Nov 10, 2021

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented Nov 5, 2021

Related issue
Closes #912

Description

This PR removes the unnecessary chkconfig dependency from RPM packages, which caused errors in OpenSUSE Tumbleweed installations.

Logs example

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@DFolchA DFolchA requested review from alberpilot and okynos November 5, 2021 16:06
@DFolchA DFolchA self-assigned this Nov 5, 2021
Copy link
Contributor

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes

@@ -467,8 +468,7 @@ if [ $1 = 0 ]; then
systemctl disable wazuh-manager > /dev/null 2>&1
systemctl daemon-reload > /dev/null 2>&1
# Check for SysV
elif command -v service > /dev/null 2>&1 ; then
chkconfig wazuh-manager off > /dev/null 2>&1
elif command -v service > /dev/null 2>&1 && command -v chkconfig > /dev/null 2>&1; then chkconfig wazuh-manager off > /dev/null 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chkconfig wazuh-manager off > /dev/null 2>&1 goes into the next line

Copy link
Contributor

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSUSE tunbleweed installation chkconfig error
2 participants