Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check the behavior of test_max_fd_win_rt option. #1387

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Add test to check the behavior of test_max_fd_win_rt option. #1387

merged 3 commits into from
Jun 17, 2021

Conversation

antoniomanuelfr
Copy link
Contributor

Related issue
#1386

Description

This PR aims to add a new integration test that checks the correct behavior of the option max_fd_win_rt
Closes #1386

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.
  • provision_documentation.sh generate the docs without errors.

@antoniomanuelfr antoniomanuelfr self-assigned this May 28, 2021
@Molter73 Molter73 requested a review from BraulioV June 7, 2021 14:46
@antoniomanuelfr antoniomanuelfr force-pushed the max_fd_win_rt_integration_test branch from dc07a42 to 67d54be Compare June 10, 2021 08:14
spothound
spothound previously approved these changes Jun 14, 2021
View reviewed changes
BraulioV
BraulioV previously approved these changes Jun 14, 2021
View reviewed changes
@antoniomanuelfr antoniomanuelfr dismissed stale reviews from BraulioV and spothound via e705add June 15, 2021 08:26
@antoniomanuelfr antoniomanuelfr force-pushed the max_fd_win_rt_integration_test branch from 67d54be to e705add Compare June 15, 2021 08:26
spothound
spothound approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@spothound spothound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Molter73
Molter73 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 merged commit 6a4d752 into master Jun 17, 2021
@vikman90 vikman90 deleted the max_fd_win_rt_integration_test branch June 17, 2021 15:42
@snaow snaow mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@spothound spothound spothound approved these changes

@BraulioV BraulioV BraulioV approved these changes

Assignees

@antoniomanuelfr antoniomanuelfr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test to check max_fd_win_rt option
5 participants
@antoniomanuelfr @BraulioV @spothound @Molter73 @vikman90