-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITs for logtest verbose mode added #1587
Conversation
951199a
to
bf46399
Compare
Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, but some changes are required
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes in daemons handling are required
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ but minor changes are required.
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logtest/test_log_process_options/test_rules_verbose.py
Outdated
Show resolved
Hide resolved
a57a2b5
to
04d9465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
04d9465
to
6de2c9a
Compare
6de2c9a
to
f728492
Compare
Description
Hi team,
This PR aims to close the issue #1584. As for the new Logtest feature, that allows it to use the verbose mode to debug the rules (see Wazuh-logtest: verbose mode #9204, we have created the following Integration Tests:
rules_debug
option is omittedrules_debug
option is set totrue
rules_debug
option is set tofalse
rules_debug
option is erroneous (string)rules_debug
option is erroneous (number)rules_debug
option is erroneous (object)rules_debug
option is erroneous (array)options
field is erroneous (boolean)options
field is erroneous (array)options
field is erroneous (number)options
field is erroneous (string)Tests
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py
.provision_documentation.sh
generate the docs without errors.