Improvements in error handling and some validations #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fcaffieri
requested changes
Mar 21, 2024
fcaffieri
approved these changes
Mar 22, 2024
teddytpc1
approved these changes
Mar 25, 2024
teddytpc1
deleted the
enhancement/4901-dtt1-iteration-3-allocator-validations-and-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4901
This PR seeks to improve error handling and some validations carried out on the tags applied to the AWS instances.
At the same time, some name definitions are corrected in the construction of the instance and the private keys used to access them, a random number is added to avoid coincidence in the keys and duplication.
The possibility of overwriting private keys is eliminated as this can be somewhat risky.
Tests:
replaced exit(1) to raise: #4901 (comment)
Improving the error message when selecting an unavailable machine: #4901 (comment)
Removing issue label as mandatory and improving ssh key naming: #4901 (comment)
Termination date options: #4901 (comment)