Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace os.getlogin for getpass.getuser #5211

Merged

Conversation

mhamra
Copy link
Contributor

@mhamra mhamra commented Apr 12, 2024

Description

Closes: #5203

The getpass.getuser function is more reliable than the os.getlogin function, this PR replace the former function call to get the current user of the process.

@mhamra
Copy link
Contributor Author

mhamra commented Apr 12, 2024

RUN EVIDENCE

This comment contains a workflow executed with the modified version of the deployability/modules/testing/testing.py source code.

Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Notes

LGTM

@rauldpm rauldpm merged commit fb7f85d into 4495-dtt1-release Apr 12, 2024
@rauldpm rauldpm deleted the enhancement/5203-replace-getlogin-for-getuser branch April 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTT1. Change the call to os.getlogin function by getpass.getuser in testing module
3 participants