Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests start before feeds are updated #5227

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Conversation

santipadilla
Copy link
Member

Related issue
#5173

Description

This PR changes the function that waits for the feed to finish. We achieve this by changing the log that tells us that the feed has finished and increasing the timeout.

@santipadilla santipadilla self-assigned this Apr 16, 2024
@santipadilla santipadilla linked an issue Apr 16, 2024 that may be closed by this pull request
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, minor change is required

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems after testing, that INFO: Feed update process completed log does not always appear in the manager.
When feeds are already downloaded, this log does not appear. This makes it impossible to test in an already prepared environment.

@santipadilla santipadilla force-pushed the 5173-wait-until-vd-is-updated branch from f720465 to 06fac6e Compare April 23, 2024 16:03
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan juliamagan merged commit 2c6bed4 into 4.8.0 Apr 30, 2024
0 of 2 checks passed
@juliamagan juliamagan deleted the 5173-wait-until-vd-is-updated branch April 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests start before feeds are updated
3 participants