Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test/test_consumer_integration.py in GitHub runner #194

Conversation

orange-kao
Copy link

test/test_consumer_integration.py::test_kafka_consumer__blocking failed in
https://github.com/wbarnha/kafka-python-ng/actions/runs/10361086008/job/28680735389?pr=186 because it took 592ms to finish. Output from the GitHub runner attached

This commit increase TIMEOUT_MS so it is less likely to fail on GitHub runner.

          # Ask for 5 messages, 10 in queue. Get 5 back, no blocking
          messages = []
          with Timer() as t:
              for i in range(5):
                  msg = next(consumer)
                  messages.append(msg)
          assert_message_count(messages, 5)
  >       assert t.interval < (TIMEOUT_MS / 1000.0)
  E       assert 0.5929090976715088 < (500 / 1000.0)
  E        +  where 0.5929090976715088 = <test.testutil.Timer object at 0x7f6c4b50e960>.interval

test/test_consumer_integration.py::test_kafka_consumer__blocking failed
in
https://github.com/wbarnha/kafka-python-ng/actions/runs/10361086008/job/28680735389?pr=186
because it took 592ms to finish. Output from the GitHub runner attached

This commit increase TIMEOUT_MS so it is less likely to fail on GitHub
runner.

          # Ask for 5 messages, 10 in queue. Get 5 back, no blocking
          messages = []
          with Timer() as t:
              for i in range(5):
                  msg = next(consumer)
                  messages.append(msg)
          assert_message_count(messages, 5)
  >       assert t.interval < (TIMEOUT_MS / 1000.0)
  E       assert 0.5929090976715088 < (500 / 1000.0)
  E        +  where 0.5929090976715088 = <test.testutil.Timer object at 0x7f6c4b50e960>.interval
@orange-kao orange-kao marked this pull request as ready for review August 13, 2024 07:13
@wbarnha wbarnha merged commit 6104623 into wbarnha:master Oct 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants