-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions CI/CD for building cross-platform(Linux, MacOS and Windows) wheels for leveldb 1.23
and snappy 1.1.9
#129
base: main
Are you sure you want to change the base?
Conversation
…eldb 1.23` and `snappy 1.1.9`
wow, i imagine this was quite some effort. thanks! 🙏 i will have a good look at this later. |
I did not realize this was here!! I have been working on this myself on a private repo because I don't want the user to need to be required to do a system install of leveldb.. I have wheels for all platforms here for python 3.6 3.7 3.8 3.9 : I've posted a PR for what it's worth. Whether you use it or not it's no worries 😄 |
Wow, @AustEcon thank you for presenting a idea to build I will try to add it into |
I have add to build windows wheel in github actions CI for Please see new commits and CI results at plyvel github actions CI |
leveldb 1.23
and snappy 1.1.9
leveldb 1.23
and snappy 1.1.9
@wbolster, when are you planning to review this PR and merge it. It will be a great help to the machine users for which wheels are missing on PyPI. |
I've also made a fork to build wheels for windows which is build against the latest leveldb version(the main branch). Should we consider release the wheels derectly since install leveldb on windows is far more harder than that on unix? I could submit anothor pr for that. |
I have released wheels built for Linux, Windows, and macOS. You can download your platform-specified |
hey @liviaerxin wow, that is fantastic! i see you built on top of my build scripts (which i only ever ran successfully in a local docker environment, not in CI) 👍🏼 it would be great if we can get this cleaned up a bit and make it official, and trigger everything from this repo. we could even do automatic releases + pypi based on git tags etc. are you interested in helping getting that set up? (i can also arrange write access to this repo of course) |
Hello @wbolster, I'm glad to participate in the following work and assist you to publish pypi/release automatically by CI to help people use |
Hello @wbolster, I have not tracked your plyvel repo for a while and see it still does not provide binary wheels for cross-platform. Now I have some time and really wish your repo to be accessible for more people especially I can add some improvement to do If you have other suggestions on CI, such as your mentioned code cleanup, feel free to tell me. Then I can kick off the pull request again and simplify it by squashing commits. |
New Features:
manylinux_x86_64
,manylinux_aarch64
,manylinux_i686
forcp37* cp38* cp39*
in Linux usingcibuildwheel
x86_64
forcp37* cp38* cp39*
anduniversal2
forcp39*
in MacOS usingcibuildwheel
win32
andx64
forcp37* cp38* cp39*
in Windows usingcibuildwheel
1.23
ofleveldb
and the version1.1.9
ofsnappy
for all platforms(Linux, MacOS, Windows)pytest
in CICheck and verify my new CI result at github actions CI/CD
Released wheels at https://github.com/liviaerxin/plyvel/releases/tag/v1.3.0-CI
TODOs:
1.3.0
forplyvel
.test_open_read_only_dir()
intest/test_plyvel.py
to pass pytest.pypi
using github action.