Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osx build issue #96

Closed
wants to merge 1 commit into from
Closed

Fix osx build issue #96

wants to merge 1 commit into from

Conversation

schmty
Copy link
Contributor

@schmty schmty commented Apr 15, 2019

Via adding the extra compile arguments of -x c++ -std=c++11 and removing platform specific code as suggested by @kyuupichan and @wbolster in #95 plyvel now builds on OSX 10.14. Fixes #95

@schmty
Copy link
Contributor Author

schmty commented Apr 15, 2019

Ok, after the first failed test I have rewritten the conditional adding arguments for Darwin/OSX. Note, in both ca97b06 and 753b0e2 have built on my system. This change is in effort to get a passing build from travis

@schmty schmty force-pushed the fix-osx-build-issue branch from 753b0e2 to ca97b06 Compare April 15, 2019 22:51
@schmty schmty force-pushed the fix-osx-build-issue branch from ca97b06 to b2c01b5 Compare April 15, 2019 22:58
@schmty
Copy link
Contributor Author

schmty commented Apr 15, 2019

having some trouble, going to close this and reopen a new PR shortly

@schmty schmty closed this Apr 15, 2019
@wbolster wbolster added the builds label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsupported leveldb 1.21 on MacOS
2 participants
@schmty @wbolster