Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and add content types #77

Closed
dalyw opened this issue Mar 14, 2024 · 1 comment · Fixed by #87
Closed

Rename and add content types #77

dalyw opened this issue Mar 14, 2024 · 1 comment · Fixed by #87
Assignees
@fletchapin
Labels
enhancement New feature or request

Comments

@dalyw
Copy link

dalyw commented Mar 14, 2024 •
edited
Loading

Use Case

  • Add "Chemical" for dosing of chemical (e.g. dosing methanol for nutrient removal)
  • Rename "untreated sewage" to using “wastewater” so it can be generalized for industrial wastewater
  • Rename “treated sewage” to "tertiary effluent" or "disinfected effluent" or something more general

Solution

Additional content types

Alternatives

Add "Other
@dalyw dalyw added enhancement New feature or request needs triage Still needs to be assigned to the correct party labels Mar 14, 2024
@dalyw dalyw changed the title Add "chemical" or "other" to content types Rename and add content types Mar 14, 2024
@fletchapin fletchapin self-assigned this Apr 16, 2024
@fletchapin fletchapin removed the needs triage Still needs to be assigned to the correct party label Apr 16, 2024
@fletchapin
Copy link
Contributor

TertiaryEffluent is already a ContentsType. For backwards compatibility I don't remove ContentsType but I have introduced the following new ContentsType (in feature/batt-attr):

  • Disinfectant
  • Coagulant
  • Chemical
  • IndustrialWastewater
  • MunicipalWastewater
  • DisinfectedEffluent

@fletchapin fletchapin mentioned this issue May 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fletchapin fletchapin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/battery-attributes we3lab/pype-schema
2 participants
@fletchapin @dalyw