Feature/battery-attributes #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 88.20% 88.70% +0.49%
==========================================
Files 18 18
Lines 1916 2399 +483
==========================================
+ Hits 1690 2128 +438
- Misses 226 271 +45 ☔ View full report in Codecov by Sentry. |
|
@jbolorinos or @dalyw I plan to merge soon, so if you have a chance to look at this PR that would be great to get another set of eyes on the code and confirm I've made all the changes you'd like! |
There was a problem hiding this comment.
Question: I see that you added design_flow, min_flow and max_flow rather than just a single flow rate. I think oftentimes in facilities, the design flow is the max rated flow. Do you have specific use cases for including a design_flow, and not just min_flow and max_flow? If it's optional to define it's fine either way.
Updates to power/speed and chemical types look good - thanks!
* Added charge rate and RTE attributes to battery * Added ContentsType for chemical dosing * Tweak to Speed units * Added hertz to unit processing * Removed units from capacity, charge, and discharge rate * Implemented FutureWarning for old syntax * Added backwards compatability with getters/setters * test_get_capacities completed * Created get_efficiencies function * Autoreformatted with black * Trying to fix getter and setter for backwards compatability * Fixed test_get_efficiencies * Still trying to figure out back compat * Forgot to import warnings, duh * Removed flake8 warnings * trying to break circular dependency * Typos in energy_capacity * Trying to avoid infinite recursion * Finally fixed the getter/setters * Fixed backwards compat with charge_rate * Typo in del_charge_rate * Added RTE getter/setter * Forgot getter/setter for leakage * Adding verbose flag * Missed variable assignment in parse_json * WIP updating flow rate logic * Reworked flow rate and pressure representation * fixed test_get_capacities * Typo in CAPACITY_ATTRS * Fixed to_json bug with capacities * Fixed line too long linter error * Extending tests to DeprecationWarnings * Fixed unused import linter error
Pull request recommendations:
Thanks for contributing! This pull request addresses the following issues: Closes #77, closes #78, closes #82, closes #83
To do so, the following changes were made:
SpeedandFrequencyadded toTagTypeIndustrialWastewater,MunicipalWastewater,Coagulant,Disinfectant,Deodorant, andChemicaladded toContentsTypecharge_rate,leakage, andrteattributes added to batteryhorsepower=>power_ratingandcapacity=>energy_capacitywithDeprecationWarningget_capacitiesandget_efficienciesfunctions provide users with convenient access to attributes in dictionary form