Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add charge_rate attribute to battery nodes #82

Closed
jbolorinos opened this issue Apr 14, 2024 · 0 comments · Fixed by #87
Closed

ENH: add charge_rate attribute to battery nodes #82

jbolorinos opened this issue Apr 14, 2024 · 0 comments · Fixed by #87
Assignees
Labels
enhancement New feature or request

Comments

@jbolorinos
Copy link
Collaborator

Use Case

Battery charge and discharge rates are often appreciably different and we should be able to reflect both properties in our battery model

Solution

Add a charge_rate attribute to Battery nodes in addition to the discharge_rate attribute

Alternatives

Another alternative is to make the capacity attribute a dictionary of the form:

"capacity": {"energy": 2000, "charge": 850, "discharge": 1000}

Which would make capacity attributes more logically consistent (i.e. currently, the battery capacity attribute refers to just the energy capacity of the battery but there are many "capacities")

@jbolorinos jbolorinos added enhancement New feature or request needs triage Still needs to be assigned to the correct party labels Apr 14, 2024
@fletchapin fletchapin self-assigned this Apr 16, 2024
@fletchapin fletchapin removed the needs triage Still needs to be assigned to the correct party label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants