Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add RTE and leakage battery node attributes #83

Closed
jbolorinos opened this issue Apr 15, 2024 · 1 comment · Fixed by #87
Closed

ENH: Add RTE and leakage battery node attributes #83

jbolorinos opened this issue Apr 15, 2024 · 1 comment · Fixed by #87
Assignees
@fletchapin
Labels
enhancement New feature or request

Comments

@jbolorinos
Copy link
Collaborator

jbolorinos commented Apr 15, 2024 •
edited
Loading

Use Case

Right now, users wanting to model RTE/leakage have to do this separately but they are attributes of all batteries so it makes sense to put them in the network model.

Solution

Add RTE,leakage attributes to battery nodes

Alternatives

Can't think of any (don't add RTE,leakage attribute to battery nodes? lol)
@jbolorinos jbolorinos added enhancement New feature or request needs triage Still needs to be assigned to the correct party labels Apr 15, 2024
@jbolorinos jbolorinos changed the title ENH: Add RTE battery node attribute ENH: Add RTE and leakage battery node attributes Apr 16, 2024
@fletchapin
Copy link
Contributor

@jbolorinos I just added discharge rate and RTE. For leakage, would it make sense for it to be a quantity with units like kWh / second?

@fletchapin fletchapin self-assigned this Apr 16, 2024
@fletchapin fletchapin removed the needs triage Still needs to be assigned to the correct party label Apr 16, 2024
@fletchapin fletchapin mentioned this issue May 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fletchapin fletchapin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/battery-attributes we3lab/pype-schema
2 participants
@jbolorinos @fletchapin