Check translation profile for resultaat value of both eindStatus and eindDatum in case of closing zaak #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLenterman
approved these changes
Jan 28, 2025
added 2 commits
January 28, 2025 13:59
…k for resultaat for eindDatum if eindDatum exists
MLenterman
force-pushed
the
GT-1113-CheckBothEindDatumAndEindStatusWhenClosingZaak
branch
from
74a28e7 to
7c06d2e
Compare
MLenterman
deleted the
GT-1113-CheckBothEindDatumAndEindStatusWhenClosingZaak
branch
|
🎉 This PR is included in version 1.22.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there are both eindStatus and eindDatum in updateZaak, and no resultaat; we should check first the default resultaat value for eindStatus (which is under endDateAndResultLastStatus) in translation profile, if not exist then we should check the default resultaat for eindDatum (which is under endCaseEndDate) in translation profile.
We used to not do this but the problem was caused because of mixing two different values with the same sessionKey name in the pipeline. When the mixing is fixed the problem is also solved.