Skip logging context cancelled warning msgs #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bboreham can you review this? I can’t assign the PR to anyone. |
|
@tomwilkie and/or @bboreham can anyone of you review/approve this? |
|
Thanks for the PR; code looks broadly fine. I think it would be slightly better if the message still went out at debug level, rather than being dropped entirely. WDYT @tomwilkie ? |
|
Thanks @bboreham, I will wait for @tomwilkie feedback and update the PR if needed. |
|
@tomwilkie do you have any preference regarding skipping Context Cancelled logs or logging them at debug level? |
|
@bboreham I haven't heard back from @tomwilkie so I'm going to go with your suggestion and update this to emit debug logs. |
Context cancellations are controlled by clients and logging this message can cause more more confusion as mentioned here: cortexproject/cortex#1279 Signed-off-by: Neeraj Poddar <[email protected]>
nrjpoddar
force-pushed
the
skipContextCancelledLog
branch
from
4869f24 to
2c39cd4
Compare
|
@bboreham can you merge this PR? Thanks! |
yeya24
pushed a commit
to yeya24/common
that referenced
this pull request
Jun 12, 2024
…odoc-typo Fixes typo in Interval godoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context cancellations are controlled by clients and logging this message can
cause more more confusion as mentioned here:
cortexproject/cortex#1279
Signed-off-by: Neeraj Poddar [email protected]