Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitoring docs #3653

Closed
opudrovs opened this issue Nov 20, 2023 · 0 comments · Fixed by #3656
Closed

Fix monitoring docs #3653

opudrovs opened this issue Nov 20, 2023 · 0 comments · Fixed by #3656
Assignees
@opudrovs
Labels
team/tangerine type/documentation Improvements or additions to documentation

Comments

@opudrovs
Copy link
Contributor

opudrovs commented Nov 20, 2023 •
edited
Loading

Minor issues to fix:

  1. A typo in image alt:

    weave-gitops-enterprise/docs/monitoring-performance.md

    Line 28 in c561e92

    ![explorer emtrics](monitoring/imgs/explorer-query-metrics-87ba3ddbfb12169b31b27e4f9ea8c722.png)

  2. Broken links pointing to add-monitoring (a branch which does not exist in weave-gitops-quickstart anymore):

WGE:

weave-gitops-enterprise/docs/monitoring-performance.md

Line 34 in c561e92

The monitoring stack is deployed as [Flux Kustomization](https://github.com/weaveworks/weave-gitops-quickstart/tree/add-monitoring) that includes:

weave-gitops-enterprise/docs/monitoring-performance.md

Line 73 in da78e16

- The monitoring stack deployed [Flux Kustomization](https://github.com/weaveworks/weave-gitops-quickstart/tree/add-monitoring) that includes:

Weave-gitops-quickstart:
https://github.com/weaveworks/weave-gitops-quickstart/blob/1ff313ab64cafb7e0911d94b82194da9b790edfb/monitoring/README.md?plain=1#L3

  1. Fix capitalization of Weave GitOps in monitoring and other docs.
@opudrovs opudrovs added type/documentation Improvements or additions to documentation team/tangerine labels Nov 20, 2023
@opudrovs opudrovs self-assigned this Nov 20, 2023
@opudrovs opudrovs changed the title Fix a typo and broken links in monitoring docs Fix monitoring docs Nov 21, 2023
This was referenced Nov 21, 2023
Merged
Merged
opudrovs added a commit that referenced this issue Nov 22, 2023
@opudrovs
Fix broken links, spaces, and capitalization of Weave GitOps (#3653)
6a1fea1 
Minor spelling fixes.

Generate protobuf definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opudrovs opudrovs

Labels
team/tangerine type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix monitoring docs weaveworks/weave-gitops-enterprise
1 participant
@opudrovs