passing service logger to bitbucket server client factory to address logger is required issue
#2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
force-pushed
the
add-bitbucket-logger
branch
from
f60c5dd to
fc4913c
Compare
|
Could this be fixed by upgrading go-git-providers https://github.com/fluxcd/go-git-providers/releases/tag/v0.15.2 ? |
|
Yes, any of the three solutions here https://github.com/weaveworks/weave-gitops-interlock/issues/425#issuecomment-1562348689 |
yiannistri
force-pushed
the
add-bitbucket-logger
branch
from
fef5de6 to
e753c64
Compare
|
I've left the fix there while I also updated go-git-providers to ensure we stay up to date. |
yiannistri
approved these changes
May 25, 2023
|
Looking at the failures |
yiannistri
force-pushed
the
add-bitbucket-logger
branch
from
e753c64 to
2f55fb7
Compare
|
I've had to revert the commit updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing logger server to bitbucket client as quick fix for https://github.com/weaveworks/weave-gitops-interlock/issues/425
Part of https://github.com/weaveworks/weave-gitops-interlock/issues/425
What changed?
Cause go-git-providers bitbucket server client does not allow empty loggers. More info in the ticket
Why was this change made?
To send a non empty logger when creating a bitbucket server client
How did you validate the change?
Added unit test around the creation and the issue but not e2e tested.