Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no manual promotion button in pipelines #3022

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: no manual promotion button in pipelines #3022

merged 1 commit into from
Jun 27, 2023

Conversation

yitsushi
Copy link
Contributor

It seems the issue was a misconfigured Notification object. I assume it was created in a "pipelines dev" environment where it was a practice to deploy the service and related resources in pipeline-system.

Fixes #3020

image
from the fluxga cluster

@yitsushi
fix: no manual promotion button in pipelines
709fe92 
It seems the issue was a misconfigured Notification object. I assume it
was created in a "pipelines dev" environment where it was a practice to
deploy the service and related resources in pipeline-system.

Fixes #3020

Signed-off-by: Balazs Nadasdi <[email protected]>
@yitsushi yitsushi added the exclude from release notes Use this label to exclude a PR from the release notes label Jun 27, 2023
@yitsushi
Copy link
Contributor Author

🤦‍♀️

=== RUN   TestCreatePullRequestInAzureDevOps
    azure_test.go:36: 
        	Error Trace:	/home/runner/work/weave-gitops-enterprise/weave-gitops-enterprise/pkg/git/azure_test.go:36
        	Error:      	Received unexpected error:
        	            	Access Denied: The Personal Access Token used has expired.
        	Test:       	TestCreatePullRequestInAzureDevOps

@yitsushi yitsushi merged commit af1db99 into main Jun 27, 2023
@yitsushi yitsushi deleted the 3020-no-promote-button branch June 27, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiannistri yiannistri yiannistri approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual promotion button in pipelines is not shown
2 participants
@yitsushi @yiannistri