Ignore docs/ and similar paths for test workflow #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squaremo
added
the
exclude from release notes
The tests workflow just runs unit tests and integration tests (make targets `integration-tests` and `unit-tests-with-coverage`). I've added some fairly conservative paths to the GitHub workflow under on.paths-ignore, so that PRs with _just_ changes to docs aren't contingent on the tests. This saves some waiting, and some resources. - docs/** # these are not involved in the tests - bin/** # scripts that are not involved in the tests In general we _do_ want to run tests if it's the workflow itself that's changed, so I've bene more specific in `.github/` and just ignored the templates. Signed-off-by: Michael Bridgen <[email protected]>
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests workflow just runs unit tests and integration tests (make targets
integration-testsandunit-tests-with-coverage). I've added some fairly conservative paths to the GitHub workflow under on.paths-ignore, so that PRs with just changes to docs aren't contingent on the tests. This saves some waiting, and some resources.In general we do want to run tests if it's the workflow itself that's changed, so I've bene more specific in
.github/and just ignored the templates.Why was this change made?
I got annoyed waiting for test retries to complete on #2909.
How did you validate the change?
We'll have to wait until it's actually run. It's tricky to test CI scripts!