Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azure devops and for bitbucket server at pull request review drop down #3062

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

ahussein3
Copy link
Contributor

Closes #3012

What changed?

  • update view pull requests code to handle different git repository

Release notes

Documentation Changes

Other follow ups

@ahussein3 ahussein3 requested a review from foot July 10, 2023 17:11
@foot
Copy link
Collaborator

foot commented Jul 11, 2023

Nice! Lets add a couple of tests for the new cases to OpenPullRequest.test.ts

@ahussein3 ahussein3 requested a review from jpellizzari as a code owner July 11, 2023 13:56
@ahussein3 ahussein3 requested a review from foot July 11, 2023 13:58
@foot
Copy link
Collaborator

foot commented Jul 11, 2023

Not sure about the ui-unit-test failures, could perhaps be an older weave-gitops in your node_modules?

yarn
yarn test -u

again maybe?

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@ahussein3 ahussein3 merged commit 5269b9a into main Jul 11, 2023
@ahussein3 ahussein3 deleted the UI-3012-UpdateViewPullRequestBtn branch July 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix up View Pull Requests for Azure/Bitbucket-server
2 participants