Allow for extra columns to be added to ExplorerTable
#3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
2766-explorer-columns
branch
from
10cee0c to
00b90d7
Compare
jpellizzari
added
enhancement
enekofb
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Nice one!
Suggestions:
- Do we need to update Extending Explorer with guidance on how to use this feature?
Verified that works:
Had a shallow look to the FE changes and tests and makes sense to me but, as usual, dont trust too much in this part of my review.
I don't think so. The component props and types will do the explaining, hopefully. |
jpellizzari
requested review from
AlinaGoaga and
foot
and removed request for
TheGostKasper and
AsmaaNabilBakr
enekofb
approved these changes
Aug 30, 2023
jpellizzari
force-pushed
the
2766-explorer-columns
branch
3 times, most recently
from
4c6152a to
c894b78
Compare
Exposes the full object to the table, which allows for other data to appear in the table
jpellizzari
force-pushed
the
2766-explorer-columns
branch
from
c894b78 to
f68e1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2766
Adds the ability for custom column data to be pulled from the
unstructuredfield of theExplorerTable. This will allow for easier adoption of<Explorer />in other parts of the UI.For example, the
queryservice backend does not know/care about an automation'ssourceRef, but we are able to dig into that field to expose it in the UI:Note: getting the value for
tenantwill be a bit trickier, based on how it is done currently, so that will be addressed in a follow up.