Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Adjust gitauth layout to remain consistent across screen sizes #3271

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

AlinaGoaga
Copy link
Contributor

Closes #3266

@AlinaGoaga AlinaGoaga added the bug Something isn't working label Aug 30, 2023
@foot
Copy link
Collaborator

foot commented Sep 4, 2023

image

The dropdown becomes very long now. I'm not sure the best way to reconcile this.

Constraints

  • "Authenticate" button should be right next to the dropdown as mentioned in the linked issue here
  • Source dropdown to select what we're authenticating should perhaps not be the width of the page (or?)

Resolve by?

  • Dropdown becomes "50%" as the above commit / description etc fields?
  • Where does the field go? (left / right aligned?)

Do we have a design in figma?

cc @mmoulian

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also! Wide screens might be rarer, and this is defo an improvement to my eyes as it stands.

Happy to merge as is and come up with another design for super wide screens later. Maybe max-widthing the entire form is another option.

@AlinaGoaga AlinaGoaga added exclude from release notes Use this label to exclude a PR from the release notes and removed bug Something isn't working labels Sep 4, 2023
@AlinaGoaga AlinaGoaga merged commit f36d549 into main Sep 4, 2023
@AlinaGoaga AlinaGoaga deleted the update-gitauth-style branch September 4, 2023 12:52
@mmoulian
Copy link

mmoulian commented Sep 4, 2023

@foot @AlinaGoaga Sure, I can do a design in Figma. I'll be able to start on this next week.
I have a high priority delivery next Monday.

@AlinaGoaga
Copy link
Contributor Author

Thanks @mmoulian ping me pls when ready (no rush)

@alfaris
Copy link

alfaris commented Oct 2, 2023

I advice that set a max width for this section to 1024px and min width to 375px

here the design
image
And let me know if I missed anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update layout in GitAuth section of the Create Resource Form
4 participants