Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric template details renders all the metrics templates in the canary instead of the one clicked #3287

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Metric template details renders all the metrics templates in the canary instead of the one clicked #3287

merged 2 commits into from
Sep 6, 2023

Conversation

TheGostKasper
Copy link
Contributor

Closes #3211

What changed?
Using setDetailModal instead of custom Modal to render metric Yaml

@TheGostKasper TheGostKasper added the bug Something isn't working label Sep 5, 2023
@TheGostKasper TheGostKasper added the enhancement New feature or request label Sep 5, 2023
joshri
joshri approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected - nice!!

@TheGostKasper TheGostKasper merged commit 40b9b58 into main Sep 6, 2023
@TheGostKasper TheGostKasper deleted the 3277 branch September 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshri joshri joshri approved these changes

@jpellizzari jpellizzari jpellizzari approved these changes

@yiannistri yiannistri Awaiting requested review from yiannistri

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CX] Metric template details renders all the metrics templates in the canary instead of the one clicked
3 participants
@TheGostKasper @jpellizzari @joshri